Skip to content

change cartridge and dll_deleter from struct to class #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

change cartridge and dll_deleter from struct to class #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcommon/include/vcc/bus/cartridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace vcc::bus
/// that can be connected to devices such as a computer or video game console to
/// provide programs and data on ROM, extra RAM, or additional hardware capabilities
/// such as a floppy disk controller or programmable sound generator.
struct LIBCOMMON_EXPORT cartridge
class LIBCOMMON_EXPORT cartridge
{
public:

Expand Down
4 changes: 3 additions & 1 deletion libcommon/include/vcc/utils/dll_deleter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ namespace vcc::utils
{

/// @brief Custom `std::unique_ptr` "deleter" for managing the lifetime of shared libraries.
struct LIBCOMMON_EXPORT dll_deleter
class LIBCOMMON_EXPORT dll_deleter
{
public:

/// @brief Release a shared library.
///
/// @param instance The handle to the shared library to release.
Expand Down
4 changes: 2 additions & 2 deletions libcommon/src/devices/serial/beckerport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,13 +197,13 @@ namespace vcc::devices::serial
// Permit retry unless urecoverable error or success
retry_ = true;

struct addrinfo hints;
addrinfo hints;
ZeroMemory(&hints, sizeof(hints));
hints.ai_family = AF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_protocol = IPPROTO_TCP;

struct addrinfo *result = nullptr;
addrinfo *result = nullptr;
if (getaddrinfo(cur_address_, cur_port_, &hints, &result) != 0) {
retry_ = false;
return;
Expand Down