Skip to content

Autohide touch controls #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JustMeDaFaq
Copy link

Added a simple possebility to define which input device got used lately.

Any input on the gamepad makes the touchscreen controls automatically disappear. Touch the screen to bring them back again :)

Added a simple possebility to define which input device got used lately.

Any input on the gamepad makes the touchscreen controls automatically disappear. Touch the screen to bring them back again :)
@rbeesley
Copy link

rbeesley commented Sep 26, 2020

Probably more appropriate for base? The Auto Hide is nice. I don't think it picks up when a controller is turned on after the game launches, but this is a good addition for now and that's something which can be changed with another update.

Edit: I understand why that was a bad suggestion now. I didn't realize that base was referencing this repo.

@JustMeDaFaq
Copy link
Author

JustMeDaFaq commented Sep 26, 2020

Probably more appropriate for base? The Auto Hide is nice. I don't think it picks up when a controller is turned on after the game launches, but this is a good addition for now and that's something which can be changed with another update.

It does pick up, whenever a controller is turned on/any controller input gets registered (no matter when the controller gets connected) while the game is running :)

@rbeesley
Copy link

It does pick up, whenever a controller is turned on/any controller input gets registered (no matter when the controller gets connected) while the game is running :)

Yup. I was just coming back here to leave that update. Maybe I just had an issue getting my controller to connect earlier, but trying it again tonight it worked as expected.

@Dominiquedb
Copy link

@JustMeDaFaq could you implement this in other branches as well?
I compiled with your fork, and the auto hide works great. But I prefer the ex and ex nightly over master, because of the extended menu and other options master doesn't have.
I tried doing it myself but failed

@JustMeDaFaq
Copy link
Author

@Dominiquedb Sorry for my late reply, gonna have a look at those tomorrow 🤓

@Dominiquedb
Copy link

@Dominiquedb Sorry for my late reply, gonna have a look at those tomorrow nerd_face

Thanks for looking into it, and your reply was actually very fast, 10 hours is definitely not a late reply

@JustMeDaFaq
Copy link
Author

JustMeDaFaq commented Oct 5, 2020

@Dominiquedb Sorry for my late reply, gonna have a look at those tomorrow nerd_face

Thanks for looking into it, and your reply was actually very fast, 10 hours is definitely not a late reply

Thanks! I added autohiding to both, ex/master and ex/nightly branches on my fork now too. Tested on my device and both are working great for me, could you test it and tell me if its working for you too?
https://github.com/JustMeDaFaq/sm64-port-android
@Dominiquedb

@Dominiquedb
Copy link

Dominiquedb commented Oct 5, 2020

@Dominiquedb Sorry for my late reply, gonna have a look at those tomorrow nerd_face

Thanks for looking into it, and your reply was actually very fast, 10 hours is definitely not a late reply

Thanks! I added autohiding to both, ex/master and ex/nightly branches on my fork now too. Tested on my device and both are working great for me, could you test it and tell me if its working for you too?
https://github.com/JustMeDaFaq/sm64-port-android
@Dominiquedb

You are the man, I just tested ex/master and ex/nightly, both work great, this auto hiding is just perfect, it really adds a lot to the app for me. Time for me to try if my phone can handle render 96

edit: just got the render96 working with the disappearing touch controls, looks beautiful, but my phone (xiaomi redmi note 8t, sd665 - 4GB ram) can't handle it at 60fps, speed will remain at 100% but the frames will drop occasionally, got as low as 19fps, still very playable but I prefer regular graphics at a stable frame rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants