Draft/experimental user dataset upload tab UX improvements#1394
Draft
Draft/experimental user dataset upload tab UX improvements#1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End of summer 2025 update
It seems that just this poorly named commit contains the business logic for upload-form-subtype remembering
e7c5235
It may be possible to cherry-pick it in to a new branch if we need it.
I'm not sure why this branch has all the other commits in it. Merging from main is a no-no!
Something to discuss in our meeting.
If the user navigates to the phenotype upload form, then the help tab, and then back to the upload form, it should
a) remember that they were on the phenotype form
b) remember anything they filled in
This PR achieves a) but I have tried several things for b) and couldn't get them to work.
keepalive-for-react- just couldn't get the basic version to work. Thereact-router-domversion requires an upgrade toreact-router-domand looks like it would require a major rewritereact-keepalive- 6 years old and didn't workOne solution would be to have the tabs all rendered but not visible, but this would require a major rewrite also.
Another solution is to keep saving the upload form state via redux.