Skip to content

Comments

Gene page open all sections#1578

Merged
aurreco-uga merged 4 commits intomainfrom
gene-page-open-all-sections
Jan 9, 2026
Merged

Gene page open all sections#1578
aurreco-uga merged 4 commits intomainfrom
gene-page-open-all-sections

Conversation

@aurreco-uga
Copy link
Member

No description provided.

@bobular
Copy link
Member

bobular commented Jan 7, 2026

Hey @copilot - please could you DRY-up the conditional rendering based on process.env.NODE_ENV in packages/sites/genomics-site/webapp/wdkCustomization/js/client/components/records/GeneRecordClasses.GeneRecordClass.jsx (L346)?

Copy link
Contributor

Copilot AI commented Jan 7, 2026

@bobular I've opened a new pull request, #1581, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* DRY-up conditional rendering based on NODE_ENV

Co-authored-by: bobular <308639+bobular@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bobular <308639+bobular@users.noreply.github.com>
@bobular
Copy link
Member

bobular commented Jan 7, 2026

I just tested copilot (I had to re-enable it after renewing my educational status) to do a trivial DRY-up and it took longer than me doing it myself!

Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I played with @copilot to make a trivial refactor. Note that you can nest { ... } sections with conditional rendering logic inside TSX regions.

Copy link
Contributor

Copilot AI commented Jan 7, 2026

@bobular I've opened a new pull request, #1582, to work on those changes. Once the pull request is ready, I'll request review from you.

@bobular
Copy link
Member

bobular commented Jan 7, 2026

Oops I should not have @-mentioned copilot in my PR review. I just had to cancel its attempt to fix something (that I didn't even ask for).

@aurreco-uga aurreco-uga merged commit b17369a into main Jan 9, 2026
1 check passed
@aurreco-uga aurreco-uga deleted the gene-page-open-all-sections branch January 9, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants