Conversation
!!!!!OMIT THIS COMMIT WHEN MERGING BACK TO MAIN!!!!!
There was a problem hiding this comment.
Looks (and works, with my minimal testing with genelist uploads to a plasmodb dev site with a fully-local vdi stack) great!
Whoever takes on the upload form and control page work from the mockups will probably want a fresh start (see my comment on packages/libs/user-datasets/src/lib/Components/UploadForm.tsx).
There was a problem hiding this comment.
We should touch base on where we are with Ann's previous work vs. the latest mockups etc.
Actually I've done a bit of detective work here.
From the blame of the previous commit, it looks like you removed a bunch of form elements etc from Ann's #1372 (and possibly #1375)
That was presumably to get things working. That UI may not be current either. We can always refer to Ann's PR to avoid reinventing that wheel. But it's probably good to start with a clean slate and a full understanding of what's needed for clinepi/dataExplorer and genomics.
There was a problem hiding this comment.
Yeah, things have changed several times since Ann's work and I didn't want to spend the effort adapting code that may not even be relevant/desired anymore.
Co-authored-by: Bob MacCallum <uncoolbob@gmail.com>
Changes