Skip to content

Comments

New VDI API compatibility update.#1583

Merged
Foxcapades merged 24 commits intomainfrom
ellie-vdi-client-update
Jan 16, 2026
Merged

New VDI API compatibility update.#1583
Foxcapades merged 24 commits intomainfrom
ellie-vdi-client-update

Conversation

@Foxcapades
Copy link
Contributor

@Foxcapades Foxcapades commented Jan 8, 2026

Changes

  • Replaces API io-ts type definitions.
  • Updates object property references for the new API types.
  • Updates API endpoint paths.
  • Removes iRODS system compatibility code which was creating significant complexity for no gain.
  • Updates patch request to use new structure.
  • Remove dead/outdated draft of the 'extra metadata' feature.
  • Adds new actions for updating datasets from the list view.
  • Comments out quota percent usage column until that calculation is re-added to the VDI dataset listing API.
  • Updates gene-list-export form-submission object structure.

@Foxcapades Foxcapades requested a review from bobular January 9, 2026 19:01
@Foxcapades Foxcapades self-assigned this Jan 9, 2026
@Foxcapades Foxcapades marked this pull request as ready for review January 13, 2026 15:50
Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (and works, with my minimal testing with genelist uploads to a plasmodb dev site with a fully-local vdi stack) great!

Whoever takes on the upload form and control page work from the mockups will probably want a fresh start (see my comment on packages/libs/user-datasets/src/lib/Components/UploadForm.tsx).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should touch base on where we are with Ann's previous work vs. the latest mockups etc.

Actually I've done a bit of detective work here.

From the blame of the previous commit, it looks like you removed a bunch of form elements etc from Ann's #1372 (and possibly #1375)

That was presumably to get things working. That UI may not be current either. We can always refer to Ann's PR to avoid reinventing that wheel. But it's probably good to start with a clean slate and a full understanding of what's needed for clinepi/dataExplorer and genomics.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, things have changed several times since Ann's work and I didn't want to spend the effort adapting code that may not even be relevant/desired anymore.

@Foxcapades Foxcapades merged commit d9ad8d6 into main Jan 16, 2026
1 check passed
@Foxcapades Foxcapades deleted the ellie-vdi-client-update branch January 16, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants