Conversation
…ble notebook readiness check
… in WdkParamNotebookCell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Get Answer]now waits for anotebook.isReady({analysisState, wdkState})check. It's optional on notebooks (defined in NotebookPresets.tsx)Note:
isReadyaccepts the fullAnalysisStaterather than just the analysis data, leaving room to gate submission on job status as well as configuration completeness should that prove necessary.Both DE and WGCNA have the checks.
I attempted to add red styling for
Required*params inWdkParamNotebookCellbut I was unable to reliably and generically detect if the parameter had been selected away from the placeholder value ("Choose a Module") because there is no formal concept of placeholder values in WDK params. Note that theisReadycheck does look for "choose_module" and is reliable for gating the submit button.