Skip to content

Conversation

@Hevagog
Copy link
Collaborator

@Hevagog Hevagog commented Apr 3, 2025

Pull Request Title

Description

Provide a concise summary of the changes proposed in this PR. Include any relevant context or background information that will help the reviewer understand the purpose of this PR.

  • Type of Change:
    • New feature
    • Bug fix
    • Code refactoring
    • Documentation update
    • Other (please describe):

Related Issues

List any issues that are related to this PR. If the PR resolves one or more issues, use keywords to automatically close them (e.g., Fixes #123, Closes #456).

  • Issue #(issue number)

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Include details on the testing environment, test cases, and any relevant configurations. If applicable, provide steps to reproduce the testing process.

  • Unit tests
  • Integration tests
  • Manual tests
  • Skip test - Please provide an explanation why you skip tests

We encourage you to keep the code coverage percentage at 90% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Testing Environment:

  • Python Version: 3.12
  • OS: Ubuntu 20.04

Screenshots (if applicable)

If your PR includes UI changes or modifications to the command-line interface (CLI), provide before and after screenshots.

Checklist

Ensure that all the following tasks are completed before submitting your PR:

  • Code is formatted and has been linted using 'makefile' run-check option
  • New and existing tests pass locally.
  • All relevant documentation has been updated (e.g., docstrings, README, etc.).
  • Dependencies have been updated, and requirements.txt or pyproject.toml has been updated accordingly.
  • This PR has been reviewed by at least one other developer.

Deployment Notes

Added functionality for max iteration count for simulation.

Hevagog and others added 5 commits March 30, 2025 14:46
Renamed and encapsulated the loop controller logic to improve clarity and adherence to private naming conventions. Updated related method and variable names to reflect the change from "iterations" to "generations" for better semantic alignment. Adjusted all usages of the loop controller across services and tests to incorporate the new parameter and structure.
@Hevagog Hevagog linked an issue Apr 3, 2025 that may be closed by this pull request
2 tasks
@dJaniga dJaniga self-requested a review April 3, 2025 17:58
Copy link
Collaborator

@dJaniga dJaniga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dJaniga dJaniga merged commit 9b5d6db into main Apr 3, 2025
1 check passed
@dJaniga dJaniga deleted the optimization-should-stop-after-n-iteration branch April 3, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimization should stop after N iteration

3 participants