Skip to content

Conversation

@Hevagog
Copy link
Collaborator

@Hevagog Hevagog commented Apr 24, 2025

Docker orchestration logging

Description

Added logging functionality to the docker orchestration, with option to log to an external terminal (using xterm) or to log to a file. One can turn this external logging terminal in pyproject.toml:

[logging.output]
external_docker_log_console = true
  • Type of Change:
    • New feature
    • Bug fix
    • Code refactoring
    • Documentation update

Related Issues

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests
  • Skip test - Please provide an explanation why you skip tests

We encourage you to keep the code coverage percentage at 90% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Testing Environment:

  • Python Version: 3.12
  • OS: e.g., Windows 10, WSL2 Ubuntu 20.04

Screenshots (if applicable)

image

Checklist

Ensure that all the following tasks are completed before submitting your PR:

  • Code is formatted and has been linted using 'makefile' run-check option
  • New and existing tests pass locally.
  • All relevant documentation has been updated (e.g., docstrings, README, etc.).
  • Dependencies have been updated, and requirements.txt or pyproject.toml has been updated accordingly.
  • This PR has been reviewed by at least one other developer.

Additional Comments

Additionally I've implemented basic refactor to the logging imports so that it complies with our approach.

@Hevagog Hevagog requested a review from dJaniga April 24, 2025 13:12
@Hevagog
Copy link
Collaborator Author

Hevagog commented May 6, 2025

@dJaniga

Copy link
Collaborator

@dJaniga dJaniga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hevagog thanks for the nice and clean implementation, requested small change as xterm is missing for release installation

@Hevagog Hevagog merged commit c4429ec into main May 10, 2025
1 check passed
@Hevagog Hevagog deleted the logging-sim-service branch May 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants