Add real simulation case #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Dockerfile and dependencies to use Python 3.10, as required by the open-darts 1.1.3 wheel. Adjusted type annotations and enums for compatibility with Python 3.10 syntax. Included the open-darts wheel in the infrastructure and updated pre-commit configuration for large file checks.
Replaced direct access to centroids_all_cells with a new utility function `_calculate_centroids`. Updated `_CellConnector` and related methods to align with this change, ensuring centroids are dynamically computed from discretization parameters. This improves maintainability and flexibility.
Standardized indentation for method parameters and reformatted complex array operations for better readability. Made minor structural adjustments to improve code clarity without altering functionality.
Removed redundant test files, streamlined Docker configurations, and improved gRPC channel/server options for handling larger message sizes. Additionally, minor adjustments were made to logging and simulation service utilities to ensure smoother execution and manage resource constraints more effectively.
…ENT_RiskManagementToolbox into add_real_simulation_case
Added .whl to .gitattributes to treat wheel files as binary and prevent potential file corruption. Updated the open_darts-1.1.3 wheel file in the worker module.
The Docker image initialization code was fully removed from the service as it is no longer in use. Additionally, the timeout handling in the `open_darts.py` connector was updated to return a consistent placeholder value (`-1e3`) instead of `inf` for simulation results.
# Conflicts: # src/interfaces/cli.py # src/services/simulation_service/core/service/__init__.py
Introduced `OptimizationStrategy` to support new optimization modes. Updated relevant files to include the new model in imports. Simplified test case setup by removing redundant mock discretizer definitions.
Hevagog
requested changes
May 10, 2025
Comment on lines
45
to
48
| dx | ||
| dy | ||
| dz | ||
| start_z |
Collaborator
There was a problem hiding this comment.
To proprely format this docstring we can implement:
- dx
- dy
- dz
- start_z
Collaborator
There was a problem hiding this comment.
The same thing goes for all other docstrings in this file
Collaborator
Author
There was a problem hiding this comment.
Could you please explain what do you mean?
Collaborator
There was a problem hiding this comment.
What is the reason for newlines between each element? When you view this class you see dx dy dz - no newline between those values as probably intended
| RUN pip install --no-cache-dir uv &&\ | ||
| uv pip install --no-cache-dir -r worker_requirements.txt --target /install | ||
|
|
||
| FROM python:3.10.12-slim |
Collaborator
There was a problem hiding this comment.
Already defined in line 1
Collaborator
Author
There was a problem hiding this comment.
here also I do not get you point, could you explain?
Collaborator
|
Could you also add to .gitignore an entry to ignore .csv files? Or at least ignore whole log folder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the codebase to handle real simulation case.
TODO will be handle in next iterations.