Refactor simulation workflow to handle statuses and timeouts. #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a `SimulationStatus` Enum to track job statuses such as SUCCESS, FAILED, and TIMEOUT. Modified core methods and classes to return both status and results, ensuring proper error handling and improved job monitoring. Updated related tests and logging for comprehensive support of the new workflow.
Hevagog
approved these changes
May 18, 2025
Collaborator
Hevagog
left a comment
Hevagog
left a comment
There was a problem hiding this comment.
Just one grammar nitpick
| # Note: dangling images are images with both <none> as their repository and tag | ||
| try: | ||
| logger.info("Pruning dangling Docker images...") | ||
| logger.info("On meantime: Pruning dangling Docker images...") |
Collaborator
There was a problem hiding this comment.
"In the meantime" instead of 'On meantime"
Updated the log message to correct a grammatical error from "On meantime" to "In the meantime." This improves clarity in the logged information during the Docker image pruning process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a
SimulationStatusEnum to track job statuses such as SUCCESS, FAILED, and TIMEOUT. Modified core methods and classes to return both status and results, ensuring proper error handling and improved job monitoring. Updated related tests and logging for comprehensive support of the new workflow.