Skip to content

Conversation

@Hevagog
Copy link
Collaborator

@Hevagog Hevagog commented Jul 16, 2025

User can pick what parameters he wants to optimize + decide if parameter should be maximize or minimize

Description

Added new field in optimization config .json file, where the end user can specify the objective direction of the optimization loop. Possible to only minimize/maximize.

  • Type of Change:
    • New feature
    • Bug fix
    • Code refactoring
    • Documentation update
    • Other (please describe):

Related Issues

Closes #42

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests
  • Skip test - Please provide an explanation why you skip tests

We encourage you to keep the code coverage percentage at 90% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Testing Environment:

  • Python Version: 3.12
  • OS: Ubuntu 20.04

Checklist

Ensure that all the following tasks are completed before submitting your PR:

  • Code is formatted and has been linted using 'makefile' run-check option
  • New and existing tests pass locally.
  • All relevant documentation has been updated (e.g., docstrings, README, etc.).
  • Dependencies have been updated in pyproject.toml, and uv.lock has been regenerated accordingly.
  • This PR has been reviewed by at least one other developer.

Deployment Notes

Now in configuration.json files other than "well_placement" field user has to specify "optimization_strategy" like so:

{
  "well_placement": [],
  "optimization_parameters": {
    "optimization_strategy": "maximize"
  }
}

@Hevagog Hevagog marked this pull request as ready for review July 16, 2025 19:20
@Hevagog Hevagog self-assigned this Jul 16, 2025
@Hevagog Hevagog requested a review from dJaniga July 17, 2025 19:33
Copy link
Collaborator

@dJaniga dJaniga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks
Could you add short description to Readme?

@dJaniga dJaniga merged commit dfa8271 into main Jul 21, 2025
1 check passed
@dJaniga dJaniga deleted the parameters-pick branch July 21, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User can pick what parameters he wants to optimize + decide if parameter should be maximize or minimize

3 participants