Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popper): add prop onReferenceHiddenChanged #8126

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 27, 2024


  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Нужно добавить возможность управлять стилями всплывающего элемента при использовании свойства hideWhenReferenceHidden

Изменения

  • Добавил свойство onReferenceHiddenChanged колбэк срабатывающий при скрытии/появлении якорного элемента
  • Добавил тесты функционала

Release notes

Улучшения

  • Для компонентов Popper, Popover и Tooltip добавлено свойство onReferenceHiddenChanged колбэк срабатывающий при скрытии/появлении якорного элемента при использовании hideWhenReferenceHidden

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 27, 2024 08:03
Copy link

codesandbox-ci bot commented Dec 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size
JS 394.9 KB (+0.17% 🔺)
JS (gzip) 119.75 KB (+0.15% 🔺)
JS (brotli) 98.38 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 347.6 KB (0%)
CSS (gzip) 43.03 KB (0%)
CSS (brotli) 34.33 KB (0%)

Copy link
Contributor

github-actions bot commented Dec 27, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 27, 2024

👀 Docs deployed

Commit de206a9

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (d0fb8bd) to head (de206a9).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8126   +/-   ##
=======================================
  Coverage   95.51%   95.52%           
=======================================
  Files         404      405    +1     
  Lines       11531    11555   +24     
  Branches     3830     3836    +6     
=======================================
+ Hits        11014    11038   +24     
  Misses        517      517           
Flag Coverage Δ
unittests 95.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Интересное решение 🤔

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 5, 2025
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 24, 2025
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team January 27, 2025 07:59
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 27, 2025
@EldarMuhamethanov EldarMuhamethanov changed the title feat(Popper): add prop getFloatingElementHiddenStyles feat(Popper): add prop onReferenceHiddenChanged Jan 29, 2025
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@EldarMuhamethanov EldarMuhamethanov merged commit e07de46 into master Feb 4, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8121/on-hide-reference-callback branch February 4, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: hideWhenReferenceHidden колбэк для Popper
4 participants