-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Popper): add prop onReferenceHiddenChanged
#8126
feat(Popper): add prop onReferenceHiddenChanged
#8126
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit de206a9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8126 +/- ##
=======================================
Coverage 95.51% 95.52%
=======================================
Files 404 405 +1
Lines 11531 11555 +24
Branches 3830 3836 +6
=======================================
+ Hits 11014 11038 +24
Misses 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Интересное решение 🤔
…back # Conflicts: # packages/vkui/src/components/Tooltip/Tooltip.tsx
…nd remove prop `getFloatingElementHiddenStyles`
getFloatingElementHiddenStyles
onReferenceHiddenChanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…onReferenceHiddenChange`. Add prop JSDoc
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Описание
Нужно добавить возможность управлять стилями всплывающего элемента при использовании свойства
hideWhenReferenceHidden
Изменения
onReferenceHiddenChanged
колбэк срабатывающий при скрытии/появлении якорного элементаRelease notes
Улучшения
Popper
,Popover
иTooltip
добавлено свойствоonReferenceHiddenChanged
колбэк срабатывающий при скрытии/появлении якорного элемента при использованииhideWhenReferenceHidden