Skip to content

Conversation

@EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 30, 2025


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Необходимо реализовать компонент Reorder для реализации перетаксивания элементов в вертикальном списке.

Изменения

  • Реализовал компонент Reorder с подкомпонентным подходом
  • Использовал Reorder внутри компонента List и Cell
  • Добавил страницу документации для компонента Reorder
  • Выпилил компонент CellDragger

Release notes

Новые компоненты

  • Reorder: Компонент для реализации перетаскивания элементов в вертикальном списке

@EldarMuhamethanov EldarMuhamethanov self-assigned this Sep 30, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 30, 2025 15:17
@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft September 30, 2025 15:17
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 88687e7

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9014/88687e7fa1795046d2213ddb63eb1bae62a170ea/pkg/@vkontakte/vkui/_pkg.tgz

Commit 88687e7

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

size-limit report 📦

Path Size
JS 428.21 KB (+0.46% 🔺)
JS (gzip) 129.73 KB (+0.5% 🔺)
JS (brotli) 105.95 KB (+0.43% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.56 KB (+0.02% 🔺)
CSS (gzip) 45.84 KB (+0.02% 🔺)
CSS (brotli) 36.31 KB (-0.04% 🔽)

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.02%. Comparing base (c55d7cb) to head (88687e7).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Reorder/Reorder.tsx 80.76% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9014      +/-   ##
==========================================
- Coverage   95.02%   95.02%   -0.01%     
==========================================
  Files         419      424       +5     
  Lines       11183    11249      +66     
  Branches     4210     4226      +16     
==========================================
+ Hits        10627    10689      +62     
- Misses        556      560       +4     
Flag Coverage Δ
unittests 95.02% <93.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review October 2, 2025 09:53
@EldarMuhamethanov EldarMuhamethanov added the no-stale Добавляет PR в исключения для автоматического закрытия label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-stale Добавляет PR в исключения для автоматического закрытия

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants