fix(Search): Исправление long placeholder #9083
Open
+153
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tungulin Привет! спасибо за правку. Можешь подмержить актуальный master? А то судя по diff сделано от очень старой ветки |
tungulin
force-pushed
the
tungulin/8559/search-fix-placeholder
branch
from
a400695 to
5b8282b
Compare
Contributor
Author
|
@EldarMuhamethanov. Привет! Ребейзнул MR |
Contributor
|
Привет, изображения загрузились как бинарные файлы, нужно включить у себя git lfs и перекомитить изображения git lfs installИли можно вообще удалить скриншоты мы их сами обновим |
Contributor
e2e tests
|
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/9083/e5c7a7882d98f2e9e98e0288f8a7d98e76a4c84e/pkg/@vkontakte/vkui/_pkg.tgzCommit e5c7a78 |
tungulin
force-pushed
the
tungulin/8559/search-fix-placeholder
branch
2 times, most recently
from
8f017cb to
e5c7a78
Compare
Contributor
Author
|
@SevereCloud. Привет! lfs штука платная - дропнул скриншоты) Еще раз ребейзнул |
vkcom-publisher
added
the
pr-needs-work
tungulin
force-pushed
the
tungulin/8559/search-fix-placeholder
branch
from
e5c7a78 to
3f87207
Compare
vkcom-publisher
removed
the
pr-needs-work
SevereCloud
requested changes
Nov 10, 2025
tungulin
force-pushed
the
tungulin/8559/search-fix-placeholder
branch
from
3f87207 to
e00c34e
Compare
tungulin
force-pushed
the
tungulin/8559/search-fix-placeholder
branch
from
e00c34e to
e302811
Compare
7 tasks
vkcom-publisher
added
the
pr-needs-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeholderоберазается скрытыми кнопками справа #8538Описание
Данный MR исправляет ширину placeholder учитывая контролы(кнопка очистки и кастомная иконка). Основывался на закрытом MR
Изменения