Skip to content

Conversation

@EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

В компонентах DateRangeInput, DateInput и CustomSelect есть свойство accessible, которое по умолчанию сейчас false. Нужно сделать, чтобы по умолчанию этот флаг был включен.

Изменения

  • В DateRangeInput, DateInput и CustomSelect включил флаг accessible по умолчанию.
  • Поправил тесты, чтобы не падали
  • Также оставил TODO на выпил этих флагов в v9

Release notes

BREAKING CHANGE

  • DateInput: флаг accessible теперь включен по умолчанию
  • DateRangeInput: флаг accessible теперь включен по умолчанию
  • CustomSelect: флаг accessible теперь включен по умолчанию

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

size-limit report 📦

Path Size
JS 426.31 KB (+0.01% 🔺)
JS (gzip) 129.11 KB (+0.02% 🔺)
JS (brotli) 105.69 KB (+0.18% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.5 KB (0%)
CSS (gzip) 45.84 KB (0%)
CSS (brotli) 36.32 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit f2525d8

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9194/f2525d8a802f5a34c6a8baf1d3f9ee69b06eec16/pkg/@vkontakte/vkui/_pkg.tgz

Commit f2525d8

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@33e96df). Learn more about missing BASE report.
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #9194   +/-   ##
=========================================
  Coverage          ?   95.04%           
=========================================
  Files             ?      420           
  Lines             ?    11202           
  Branches          ?     4219           
=========================================
  Hits              ?    10647           
  Misses            ?      555           
  Partials          ?        0           
Flag Coverage Δ
unittests 95.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Что насчет сразу задепрекейтить свойство

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants