-
Notifications
You must be signed in to change notification settings - Fork 197
feat(DateRangeInput,DateInput,CustomSelect): turn on accessible flag by default #9194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(DateRangeInput,DateInput,CustomSelect): turn on accessible flag by default #9194
Conversation
size-limit report 📦
|
e2e tests |
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9194/f2525d8a802f5a34c6a8baf1d3f9ee69b06eec16/pkg/@vkontakte/vkui/_pkg.tgzCommit f2525d8 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9194 +/- ##
=========================================
Coverage ? 95.04%
=========================================
Files ? 420
Lines ? 11202
Branches ? 4219
=========================================
Hits ? 10647
Misses ? 555
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Что насчет сразу задепрекейтить свойство
TODO [>=8]#8972Описание
В компонентах
DateRangeInput,DateInputиCustomSelectесть свойствоaccessible, которое по умолчанию сейчасfalse. Нужно сделать, чтобы по умолчанию этот флаг был включен.Изменения
DateRangeInput,DateInputиCustomSelectвключил флаг accessible по умолчанию.Release notes
BREAKING CHANGE
accessibleтеперь включен по умолчаниюaccessibleтеперь включен по умолчаниюaccessibleтеперь включен по умолчанию