Skip to content

Fix estimate to assume 16 tags #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razmser merged 1 commit into from
Jun 18, 2025
Merged

Fix estimate to assume 16 tags #1952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/data_model/bucket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
)

const DefaultStringTopCapacity = 100 // if capacity is 0, this one will be used instead
const oldTagNumber = 16

type (
TagUnion struct {
Expand Down Expand Up @@ -383,8 +384,9 @@ func (s *MultiItem) FinishStringTop(rng *rand.Rand, capacity int) float64 {
//}

func (s *MultiItem) RowBinarySizeEstimate() int {
keySize := 4 + 4 + format.MaxTags*4 // time, metric, tags
for _, st := range s.Key.STags { // stags
// we don't want sampling to jump, so we keep assuming that key is still 16 tags
keySize := 4 + 4 + oldTagNumber*4 // time, metric, tags
for _, st := range s.Key.STags { // stags
keySize += len(st)
}
size := keySize + s.Tail.RowBinarySizeEstimate()
Expand Down