-
Notifications
You must be signed in to change notification settings - Fork 139
xcframeworkにmacOS向けのライブラリも同梱する #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3a72139
build: macOS向けのFrameworkのテンプレートの追加
yamachu adedab5
build: iOS向けだけではないため、renameし、macOS向けのビルドに変更
yamachu cc01a12
build: workflowにも変更したビルドスクリプトを読むように変更
yamachu f555364
docs: xcframeworkの内部構造が変わったため、追従
yamachu a5e2a89
Rustのtoolchainの対応に合わせて、11.0までサポートにする
yamachu 63fc3a2
iOSなどの端末にしか無いプロパティを含めてしまっていたため削除
yamachu c08ea29
VOICEVOXのmacOSのサポートも13.0ベースだったのもあり、そっちに合わせる
yamachu a9e5f11
FrameworkのTemplateディレクトリの名前をiosやmacosなど、archではなくてplatformの名前に変更
yamachu e194c4d
ループ内のif文を排除し、platform依存の処理を分離する
yamachu 8df9ecd
Update .github/workflows/build_and_deploy.yml
yamachu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. iosのみではなくなったため、ファイル名からiosを削除している |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
crates/voicevox_core_c_api/xcframework/Frameworks/arm64/voicevox_core.framework/Info.plist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>BuildMachineOSBuild</key> | ||
| <string>23B81</string> | ||
| <key>CFBundleDevelopmentRegion</key> | ||
| <string>en</string> | ||
| <key>CFBundleExecutable</key> | ||
| <string>voicevox_core</string> | ||
| <key>CFBundleIdentifier</key> | ||
| <string>jp.hiroshiba.voicevox.voicevox-core</string> | ||
| <key>CFBundleInfoDictionaryVersion</key> | ||
| <string>6.0</string> | ||
| <key>CFBundleName</key> | ||
| <string>voicevox_core</string> | ||
| <key>CFBundlePackageType</key> | ||
| <string>FMWK</string> | ||
| <key>CFBundleShortVersionString</key> | ||
| <string>1.0</string> | ||
| <key>CFBundleSupportedPlatforms</key> | ||
| <array> | ||
| <string>MacOSX</string> | ||
| </array> | ||
| <key>CFBundleVersion</key> | ||
| <string>1</string> | ||
| <key>DTCompiler</key> | ||
| <string>com.apple.compilers.llvm.clang.1_0</string> | ||
| <key>DTPlatformBuild</key> | ||
| <string>21C52</string> | ||
| <key>DTPlatformName</key> | ||
| <string>macosx</string> | ||
| <key>DTPlatformVersion</key> | ||
| <string>13.0</string> | ||
| <key>DTSDKBuild</key> | ||
| <string>21C52</string> | ||
| <key>DTSDKName</key> | ||
| <string>macosx13.0</string> | ||
| <key>DTXcode</key> | ||
| <string>1510</string> | ||
| <key>DTXcodeBuild</key> | ||
| <string>15C65</string> | ||
| <key>MinimumOSVersion</key> | ||
| <string>11.0</string> | ||
| </dict> | ||
| </plist> |
6 changes: 6 additions & 0 deletions
6
..._core_c_api/xcframework/Frameworks/arm64/voicevox_core.framework/Modules/module.modulemap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| framework module voicevox_core { | ||
| umbrella header "voicevox_core.h" | ||
| export * | ||
|
|
||
| module * { export * } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # xcframeworkフォルダの内容について | ||
| ## Frameworks | ||
|
|
||
| iOS向けの配布ライブラリXCFramework内のFrameworkを作るための雛形です。 | ||
| 雛形は端末用とシミュレータ用の2種類です。 | ||
| iOSとmacOS向けの配布ライブラリXCFramework内のFrameworkを作るための雛形です。 | ||
| 雛形はiOS端末用(aarch64)とシミュレータ用(sim)、およびmacOS端末用(arm64)の3種類です。 | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.