Open
Conversation
630709c to
698b288
Compare
698b288 to
d7df8e6
Compare
Hiroshiba
reviewed
Nov 13, 2025
Member
Hiroshiba
left a comment
There was a problem hiding this comment.
PR内にwhyが書かれてなさそうで、目的が不明瞭かもです!
qryxip
added a commit
that referenced
this pull request
Nov 15, 2025
Hiroshiba
reviewed
Jan 15, 2026
Hiroshiba
reviewed
Jan 15, 2026
| @@ -0,0 +1,27 @@ | |||
| name: Cache ONNX Runtime | |||
| description: voicevox-ortクレートがダウンロードするONNX Runtimeをキャッシュする。voicevox-ortがシンボリックリンクを利用するmacOSとLinuxだけ対象で、Windowsは対象外。 | |||
Member
There was a problem hiding this comment.
これaction名から予測できないですね!
重要だし簡単に反映できそうだしで、action名をcache-onnxruntime-xymlinkとかにしても良いかも?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
#1192 の解決が主目的だが、voicevox-ort-sysクレートの再コンパイル防止によるCIの効率化も図る。
#1151 を見越し、
build_and_deployに対しては行わない。関連 Issue
Fixes: #1192
その他