Skip to content

ci: build_xcframeworkbuild_java_packageもmainで動かす#1230

Merged
qryxip merged 1 commit intoVOICEVOX:mainfrom
qryxip:pr/ci-fixup-1229
Dec 9, 2025
Merged

ci: build_xcframeworkbuild_java_packageもmainで動かす#1230
qryxip merged 1 commit intoVOICEVOX:mainfrom
qryxip:pr/ci-fixup-1229

Conversation

@qryxip
Copy link
Member

@qryxip qryxip commented Dec 9, 2025

内容

#1229 ではbuild_xcframeworkbuild_java_packageが対象外になってしまったので、この二つも動くようにする。
(#1229 (comment))

このPRでは問題箇所の修正のみに留める。

関連 Issue

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方針はLGTMで、あとは念の為にAIチェックしておくと良いかもくらいの気持ち!
(別にCopilot君信じてそのままマージでも良さそう)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug introduced in PR #1229 where the build_xcframework and build_java_package jobs were not running on the main branch. The fix adds the missing github.ref != 'refs/heads/main' condition to both jobs' if statements so they now correctly run on main branch, release events, and manual workflow_dispatch events (i.e., when IS_SIMPLE_TEST is false).

Key changes:

  • Updated build_xcframework job condition to include main branch checks
  • Updated build_java_package job condition to include main branch checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qryxip
Copy link
Member Author

qryxip commented Dec 9, 2025

https://github.com/VOICEVOX/voicevox_core/actions/runs/20047798262?pr=1230
foojayが一日中503 Service Temporarily Unavailableを返し続けている…。

plugins {
// Apply the foojay-resolver plugin to allow automatic download of JDKs
id 'org.gradle.toolchains.foojay-resolver-convention' version '0.4.0'
}

@qryxip qryxip merged commit 6d1b1d6 into VOICEVOX:main Dec 9, 2025
115 of 125 checks passed
@qryxip qryxip deleted the pr/ci-fixup-1229 branch December 9, 2025 22:22
Hiroshiba added a commit that referenced this pull request Dec 10, 2025
#1230 で`build_java_package`ジョブをmainブランチでも実行するようにしたが、
Java API artifactのアップロード条件に`deploy`チェックが残っていたため、
mainブランチへのpushでartifactがアップロードされず、ジョブが失敗していた。

`build_xcframework`のartifactアップロードと同様に、`deploy`条件を削除。

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
qryxip pushed a commit that referenced this pull request Dec 10, 2025
#1230 で`build_java_package`ジョブをmainブランチでも実行するようにした
が、Java API artifactのアップロード条件に`deploy`チェックが残っていたた
め、mainブランチへのpushでartifactがアップロードされず、ジョブが失敗して
いた。

`build_xcframework`のartifactアップロードと同様に、`deploy`条件を削除。

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants