Skip to content

ci: 不足していたパターンをon.pull_request.pathsに追加#1274

Merged
qryxip merged 1 commit intoVOICEVOX:mainfrom
qryxip:pr/ci-add-more-patterns-to-on-pull-request-paths
Jan 9, 2026
Merged

ci: 不足していたパターンをon.pull_request.pathsに追加#1274
qryxip merged 1 commit intoVOICEVOX:mainfrom
qryxip:pr/ci-add-more-patterns-to-on-pull-request-paths

Conversation

@qryxip
Copy link
Member

@qryxip qryxip commented Jan 7, 2026

内容

#1272 で得られた気付きをもとに、足りてなかったと思われるパターンを埋める。

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing qryxip:pr/ci-add-more-patterns-to-on-pull-request-paths (0826fd9) with main (d6eb31b)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 14 untouched benchmarks
⏩ 8 skipped benchmarks1

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Hiroshiba Hiroshiba requested a review from Copilot January 7, 2026 18:33
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(テスト落ちてるけど)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds missing path patterns to GitHub Actions workflow trigger configurations based on insights from issue #1272. The changes ensure workflows are triggered when relevant dependency files and configurations are modified.

Key changes:

  • Added Gradle build file pattern to Java linting workflow
  • Added Rust toolchain and cargo config paths to downloader build workflow
  • Expanded benchmark workflow triggers to include macro crates, models, and core Rust configuration

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/java_lint.yml Added lib/build.gradle to trigger the workflow when the library-specific Gradle build configuration changes
.github/workflows/download_test.yml Added commented-out patterns for Rust toolchain files to maintain consistency with active workflows (already disabled)
.github/workflows/build_and_deploy_downloader.yml Added .cargo/config.toml and .github/actions/rust-toolchain-from-file/** to ensure workflow runs when Rust build configuration or toolchain setup changes
.github/workflows/benchmarks.yml Added paths for cargo config, macro crate sources, model files, and rust-toolchain to capture all dependencies affecting benchmark results

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qryxip qryxip merged commit acd3267 into VOICEVOX:main Jan 9, 2026
95 of 98 checks passed
@qryxip qryxip deleted the pr/ci-add-more-patterns-to-on-pull-request-paths branch January 9, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants