e2e系テストだけOS多めで、単体テストは１つのOSで#547
Merged
Hiroshiba merged 6 commits intoVOICEVOX:mainfrom Jul 26, 2023
Hidden character warning
The head ref may contain hidden characters: "e2e\u7cfb\u30c6\u30b9\u30c8\u3060\u3051OS\u591a\u3081\u3067\u3001\u5358\u4f53\u30c6\u30b9\u30c8\u306f\uff11\u3064\u306eOS\u3067"
Merged
Conversation
Member
Author
|
まあ合計で１０分ほど（並列だと１～２分ほど？）早くなった･･･かなぁ？ってとこでした。 |
qryxip
reviewed
Jul 25, 2023
qryxip
reviewed
Jul 25, 2023
qryxip
reviewed
Jul 25, 2023
Co-authored-by: Ryo Yamashita <qryxip@gmail.com>
Hiroshiba
commented
Jul 25, 2023
Member
Author
|
e2eがエラーになってますね、linkingエラー･･･？ ↓win2019 ↓ubuntu-22 |
Member
Author
|
テスト通ってますがなんか不安なので再実行してみます。 |
Member
Author
|
成功してそうだったのでマージします！！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
テスト時間を減らすためのプルリクエストです。
endtoendテストだけは全OSで行って、単体テストは単一のOSのみで行うようにしてみました。
テスト指定方法はこちらのコメントを参考にさせていただきました。
rust-lang/cargo#10491 (comment)
関連 Issue
その他
長いのはendtoendテストな気がするし、あまりあまり意味がないかも･･･。