Conversation
Member
Author
|
そういえば： このJava APIは GitHub PackagesのGradleレジストリ で配布できたら嬉しいなと思ってます。今のvoicevox_mobileはpostinstallで入れていて、少し行儀が悪いので。 |
Member
|
#553 をマージしたので、少なくとも |
Member
Author
|
mainをマージしました。rust-lintが通ったので大丈夫のはずです |
qryxip
approved these changes
Aug 18, 2023
3 tasks
Hiroshiba
reviewed
Aug 28, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
一応全部目通してみました！！お疲れ様でした！！！！！
コメントをいくつか書いていますが、多分微調整だけなので割とすぐにマージできるのかなと。
ちなみにですがこのコードを書く時どのような感じで実装されましたか？ 👀
何かをコピペして規則的に変換していったとか、あるいはPython APIとかを見ながら全部書き下したとか。
crates/voicevox_core_java_api/lib/src/main/resources/dll/linux-arm64/.gitkeep
Outdated
Show resolved
Hide resolved
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
Member
Author
インターフェースはPython APIベースですが、それ以外は書き下ろしました。 |
qryxip
approved these changes
Aug 29, 2023
Hiroshiba
reviewed
Aug 30, 2023
Hiroshiba
approved these changes
Aug 30, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！！！ お疲れ様でした！！！
一箇所だけコメントしているので、そのやり取りが完了したらマージかなと思います！
（あとissue作成）
Member
|
問題ないと思うのでマージしたいと思います！ （コミットメッセージ間違えました、すみません。。） |
3 tasks
qryxip
added a commit
to qryxip/voicevox_core
that referenced
this pull request
Sep 3, 2023
This was referenced Sep 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
Java APIをjni-rsで実装します。
関連 Issue
その他
（なし）