Draft
Conversation
Member
|
PRありがとうございます! 1600行の更新、なるほどです。 ただまあ、今回は仕方ないということにして、APIの設計があまり変わっていないのであれば、ほぼレビューなしでマージすることも可能かもしれません。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
Synthesizserの改革を行います。#553 (comment)
SynthesisEngineを解体し、Synthesizser内にSynthesizserをSynthesizser<impl Borrow<OpenJTalk> + ...> | Synthesizser<()>にcompatible_engineに至るまで)にndarrayを要求関連 Issue
#545
その他