Open
Conversation
Member
Author
Hiroshiba
reviewed
Jan 26, 2024
Member
Author
具体的にどんな感じです?(ツールバーの一番左がMenuBar代わり) |
Member
|
@sevenc-nanashi ニュアンスはこんなかんじかなと! メニューバーを開いたり、設定を開いたりは頻度が低いから上。 (あくまで考え方の1つって感じかなと) |
Member
Author
Member
|
かといってメニュー開くボタンが他のボタンほど使われるのか微妙な気がするんですよね…。 |
Hiroshiba
approved these changes
Jan 27, 2024
Member
Hiroshiba
left a comment
There was a problem hiding this comment.
ほぼLGTMです!
気に入ったとこだけ変更してマージしていただければ!
ちなみにこれってサクッと試せるんでしたっけ👀
src/components/HeaderBar.vue
Outdated
| @@ -1,5 +1,22 @@ | |||
| <template> | |||
| <q-header class="q-py-sm"> | |||
| <q-toolbar v-if="isMobile" class="bg-primary text-white"> | |||
Member
There was a problem hiding this comment.
ここ、コンテナとプレゼンター分けて、モバイル用のプレゼンター入れた方がいい気がしますね〜
リファクタリング箇所がわかってきた。
Member
There was a problem hiding this comment.
デフォルトスタイル選択とかってどこにいくことになりそうでしょう
Member
There was a problem hiding this comment.
なるほどです。
設定への遷移をプロジェクト選択画面に持たせる場合、3遷移になって流石に遠いかもですねぇ。
(そもそもスマホアプリでそんな細かい設定があるものなのか知らないですが。。)
Member
Author
|
VITE_TARGETの分岐はほとんどないので、
で動くと思います。 |
sevenc-nanashi
commented
Mar 30, 2024
Comment on lines
+279
to
+282
| // 1フレーム遅らせることで、真っ白の画面が表示されるのを防ぐ。 | ||
| requestAnimationFrame(() => { | ||
| SplashScreen.hide(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



内容
タイトル通り。
関連 Issue
(なし)
スクリーンショット・動画など
(なし)
その他
(なし)