Conversation
- env.jsonを追加し、参照するリソースリポジトリのバージョンを定義 - make_docs.pyがenv.jsonからバージョンを読み込むように変更 - MAINTENANCE.mdにenv.jsonについての説明を追加 close #43 のフェーズ1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to pin resource repository versions by introducing a centralized env.json configuration file. The changes enable controlled version management of external VOICEVOX resource dependencies.
Key Changes:
- Added
env.jsonto define default resource repository versions (VOICEVOX and VOICEVOX Nemo) - Enhanced
make_docs.pywith argument parsing to accept resource references fromenv.jsonor command-line overrides - Updated documentation to reflect the new version management workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| env.json | Introduces version configuration with pinned versions "0.25.0" for both VOICEVOX resource repositories |
| scripts/make_docs.py | Adds argument parsing, load_env() function, and updates URL construction to use configurable references instead of hardcoded "main" branch |
| docs/MAINTENANCE.md | Updates maintenance documentation to include the new step of updating env.json before running scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
たぶん問題ないのでマージします！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
リソースリポジトリの参照バージョンを固定できるようにしました。
env.jsonでresourceリポジトリのバージョンを定義できるようにしています。関連 Issue
ref #43 のフェーズ1
スクリーンショット・動画など
N/A
その他
env.jsonをJSON形式にした理由は、シェルスクリプト・Python・GitHub Actionsのいずれからも読みやすい形式であるためです。