Skip to content

Expose schedule with ETAs in check#138

Merged
jonathf merged 1 commit intomainfrom
check_sol
Mar 26, 2026
Merged

Expose schedule with ETAs in check#138
jonathf merged 1 commit intomainfrom
check_sol

Conversation

@blegat
Copy link
Copy Markdown
Collaborator

@blegat blegat commented Mar 22, 2026

To be consistent with

.def("_solve",

and
.def("_solve",

we rename check to _check for the wrapped C++ method.
Then create a check python function (again, consistently with the solve python function) that wraps the solution, making it easy to access the schedule with ETAs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.6%. Comparing base (80a84ad) to head (78ec7c1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #138   +/-   ##
=====================================
  Coverage   79.5%   79.6%           
=====================================
  Files         29      29           
  Lines       1902    1907    +5     
  Branches     149     149           
=====================================
+ Hits        1513    1518    +5     
  Misses       377     377           
  Partials      12      12           
Flag Coverage Δ
binding 71.7% <100.0%> (ø)
python 92.2% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@jonathf jonathf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I ldidn't noticed the return value had change.

@jonathf jonathf merged commit d0500ee into main Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants