Skip to content

harden: sanitize child_process call in integrity.js... #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

harden: sanitize child_process call in integrity.js... #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion integrity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ function getSums (data) {
function getFile (url) {
// the "easy way"; returns file buffer
const filename = url.substring(url.lastIndexOf('/')+1)
cp.execSync(`curl -Lso /tmp/${filename} ${url}`)
// use execFileSync (no shell) with an argument array so the url/filename
// cannot be interpreted as shell metacharacters, preventing command injection
cp.execFileSync('curl', ['-Lso', `/tmp/${filename}`, url])
const contents = fs.readFileSync(`/tmp/${filename}`)
fs.unlinkSync(`/tmp/${filename}`) // delete tmp file
return contents
Expand Down