fix: ensure build stops if prepare_vscode fails#2831
Open
Iheb-AG wants to merge 1 commit into
Open
Conversation
Add error handling for preparation step in build script
Member
|
It already taken care with Which error does it fail to catch? |
Author
|
You're right that set -e covers most failures. However, during local testing, I found that if prepare_vscode.sh is sourced, certain shell environments allowed build.sh to continue despite internal errors. This explicit check ensures the build strictly halts the moment preparation fails, preventing the system from wasting resources on a broken build process. |
Member
Can you be more explicit? |
Author
|
I am using fish as my shell. When running the build, I noticed that if an error happens inside the sourced prepare_vscode.sh, the main build.sh doesn't always stop—it just keeps going. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error handling for preparation step in build script