Skip to content

fix: ensure build stops if prepare_vscode fails#2831

Open
Iheb-AG wants to merge 1 commit into
VSCodium:masterfrom
Iheb-AG:Iheb-AG-patch-1
Open

fix: ensure build stops if prepare_vscode fails#2831
Iheb-AG wants to merge 1 commit into
VSCodium:masterfrom
Iheb-AG:Iheb-AG-patch-1

Conversation

@Iheb-AG

@Iheb-AG Iheb-AG commented May 11, 2026

Copy link
Copy Markdown

Add error handling for preparation step in build script

Add error handling for preparation step in build script
@daiyam

daiyam commented May 11, 2026

Copy link
Copy Markdown
Member

It already taken care with set -ex.

Which error does it fail to catch?

@Iheb-AG

Iheb-AG commented May 11, 2026

Copy link
Copy Markdown
Author

You're right that set -e covers most failures. However, during local testing, I found that if prepare_vscode.sh is sourced, certain shell environments allowed build.sh to continue despite internal errors. This explicit check ensures the build strictly halts the moment preparation fails, preventing the system from wasting resources on a broken build process.

@daiyam

daiyam commented May 11, 2026

Copy link
Copy Markdown
Member

certain shell environments

Can you be more explicit?

@Iheb-AG

Iheb-AG commented May 11, 2026

Copy link
Copy Markdown
Author

I am using fish as my shell. When running the build, I noticed that if an error happens inside the sourced prepare_vscode.sh, the main build.sh doesn't always stop—it just keeps going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants