Skip to content

feat: add support for smol runtime#104

Merged
Vaiz merged 14 commits into
mainfrom
smol
Jul 19, 2025
Merged

feat: add support for smol runtime#104
Vaiz merged 14 commits into
mainfrom
smol

Conversation

@Vaiz

@Vaiz Vaiz commented Jul 19, 2025

Copy link
Copy Markdown
Owner

No description provided.

@Vaiz Vaiz requested a review from Copilot July 19, 2025 13:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Smol async runtime to the NFS3 client, enabling users to choose between Tokio and Smol runtimes based on their needs. The implementation follows the same pattern as the existing Tokio support by providing runtime-specific wrapper types and connector implementations.

Key changes:

  • New SmolConnector and SmolIo wrapper types for Smol runtime integration
  • Feature flag configuration to enable optional Smol support
  • Documentation and examples demonstrating Smol usage

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/nfs3_client/src/smol.rs New module implementing Smol-specific IO wrappers and TCP connector
crates/nfs3_client/src/lib.rs Exports the new smol module under feature flag
crates/nfs3_client/examples/nfs_smol.rs Example demonstrating NFS client usage with Smol runtime
crates/nfs3_client/examples/nfs.rs Updated with auth_unix credential usage and improved error formatting
crates/nfs3_client/README.md Added documentation for both Tokio and Smol runtime usage
crates/nfs3_client/Cargo.toml Added smol feature flag and dependencies
Cargo.toml Added workspace-level smol and socket2 dependencies
.vscode/mcp.json Added logging configuration for rust-mcp-server
Comments suppressed due to low confidence (1)

Comment thread crates/nfs3_client/src/smol.rs Outdated
Comment thread crates/nfs3_client/README.md Outdated
@Vaiz Vaiz merged commit c54d796 into main Jul 19, 2025
13 checks passed
@Vaiz Vaiz deleted the smol branch July 19, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants