Conversation
Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Smol async runtime to the NFS3 client, enabling users to choose between Tokio and Smol runtimes based on their needs. The implementation follows the same pattern as the existing Tokio support by providing runtime-specific wrapper types and connector implementations.
Key changes:
- New
SmolConnectorandSmolIowrapper types for Smol runtime integration - Feature flag configuration to enable optional Smol support
- Documentation and examples demonstrating Smol usage
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
crates/nfs3_client/src/smol.rs |
New module implementing Smol-specific IO wrappers and TCP connector |
crates/nfs3_client/src/lib.rs |
Exports the new smol module under feature flag |
crates/nfs3_client/examples/nfs_smol.rs |
Example demonstrating NFS client usage with Smol runtime |
crates/nfs3_client/examples/nfs.rs |
Updated with auth_unix credential usage and improved error formatting |
crates/nfs3_client/README.md |
Added documentation for both Tokio and Smol runtime usage |
crates/nfs3_client/Cargo.toml |
Added smol feature flag and dependencies |
Cargo.toml |
Added workspace-level smol and socket2 dependencies |
.vscode/mcp.json |
Added logging configuration for rust-mcp-server |
Comments suppressed due to low confidence (1)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.