feat: implement additional traits for nfs types#106
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements additional traits for NFS3 types to improve ergonomics and reduce unnecessary cloning. The changes focus on adding Copy, Default, and Clone traits to various NFS3 types and updating code to utilize these new capabilities.
Key changes include:
- Adding
CopyandDefaulttraits to core NFS3 types like enums and small structs - Implementing
#[default]attributes on enum variants to specify default values - Updating code to use direct assignment instead of cloning for
Copytypes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/nfs3_types/src/nfs3.rs |
Adds Copy, Default, and Clone traits to NFS3 types with default enum variants |
crates/nfs3_server/src/nfs_handlers.rs |
Removes unnecessary clone operation for Copy type |
crates/nfs3_server/src/memfs/mod.rs |
Updates function signatures to use references and removes unnecessary clones |
Comments suppressed due to low confidence (1)
crates/nfs3_types/src/nfs3.rs:987
- The enum name NFS_PROGRAM should follow Rust naming conventions and be PascalCase, e.g., NfsProgram instead of NFS_PROGRAM.
pub enum NFS_PROGRAM {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.