Skip to content

fix: small fixes#110

Merged
Vaiz merged 3 commits into
mainfrom
fixes
Jul 26, 2025
Merged

fix: small fixes#110
Vaiz merged 3 commits into
mainfrom
fixes

Conversation

@Vaiz

@Vaiz Vaiz commented Jul 26, 2025

Copy link
Copy Markdown
Owner

No description provided.

@Vaiz Vaiz requested a review from Copilot July 26, 2025 13:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the representation of optional attributes in the NFS3 server implementation by replacing the NFS3-specific post_op_attr wrapper type with Rust's native Option<fattr3> type. This change simplifies the API and makes it more idiomatic Rust code.

Key changes:

  • Replaced post_op_attr enum with Option<fattr3> for optional file attributes
  • Updated field name from handle to name_handle in DirEntryPlus struct for clarity
  • Removed unused imports of post_op_attr and Nfs3Option types

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/nfs3_server/src/vfs/mod.rs Updated imports to include post_op_attr and removed fattr3
crates/nfs3_server/src/vfs/iterator.rs Changed DirEntryPlus to use Option<fattr3> and renamed handle field to name_handle
crates/nfs3_server/src/vfs/adapters/mod.rs Updated pattern matching from Nfs3Option::Some to Some for optional attributes
crates/nfs3_server/src/vfs/adapters/iterator.rs Updated test cases to use new field names and optional attribute format
crates/nfs3_server/src/memfs/mod.rs Updated memfs iterator to use new optional attribute format
crates/nfs3_server/examples/mirrorfs.rs Updated mirrorfs example to use new optional attribute format
crates/cargo_nfs3_server/src/mirror.rs Updated cargo mirror implementation to use new optional attribute format

Comment thread crates/nfs3_server/src/vfs/mod.rs
@Vaiz Vaiz merged commit a684abf into main Jul 26, 2025
13 checks passed
@Vaiz Vaiz deleted the fixes branch July 26, 2025 13:51
@github-actions github-actions Bot mentioned this pull request Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants