Re-export nfs3_types from nfs3_server and nfs3_client crates#94
Conversation
Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
|
@copilot, in |
…ct nfs3_types dependency Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
Updated |
|
Can you check examples too? |
…s3_types imports Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
Updated all examples to use appropriate reexports. The examples now use |
|
@copilot , ci is failing, can you fix the issues? |
Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
fix this warning too |
| gids: vec![], | ||
| }; | ||
| let credential = nfs3_types::rpc::opaque_auth::auth_unix(&auth_unix); | ||
| let credential = nfs3_client::nfs3_types::rpc::opaque_auth::auth_unix(&auth_unix); |
There was a problem hiding this comment.
try to avoid long paths by importing types. This issue persist through whole PR
There was a problem hiding this comment.
Fixed by adding proper imports and replacing long paths with shorter imported names throughout all examples. The examples now use clean imports like PMAP_PORT, auth_unix, and opaque_auth instead of the long nfs3_client::nfs3_types::* paths. (3c7e17a)
Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
... Fixed the clippy uninlined-format-args warning by changing |
…lity Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
This PR addresses the issue where users of
nfs3_clientandnfs3_servercrates were forced to addnfs3_typesas a separate dependency to access the types used in the APIs.Changes Made
pub use nfs3_types;to bothcrates/nfs3_client/src/lib.rsandcrates/nfs3_server/src/lib.rsBefore
Users had to add both dependencies to their
Cargo.toml:And import types directly from
nfs3_types:After
Users only need the main crate dependency:
And can access all types through the convenient re-exports:
Testing
nfs3_typesThis change maintains full backward compatibility while providing a more convenient API for users.
Fixes #93.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.