Skip to content

feat(ui): improve search bar visuals #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanthor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ui): improve search bar visuals #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc50ff
feat(ui): improve search bar visuals with focus indicator and green b…
hanthor Jan 13, 2026
215daad
fix: Update search title instead of label during filtering
hanthor Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/services/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (s *AppService) BuildApp() {
headerName := AppName
if s.IsBrewfileMode() {
headerName = fmt.Sprintf("%s [Brewfile Mode]", AppName)
s.layout.GetSearch().Field().SetLabel("Search (Brewfile): ")
s.layout.GetSearch().Field().SetTitle("Search (Brewfile)")
s.inputService.EnableBrewfileMode() // Add Install All action
}
s.layout.GetHeader().Update(headerName, AppVersion, s.brewVersion)
Expand Down
15 changes: 13 additions & 2 deletions internal/ui/components/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,24 @@ func NewSearch(theme *theme.Theme) *Search {
theme: theme,
}

search.field.SetLabel(tview.Escape("Search (All): "))
search.field.SetLabelColor(theme.SearchLabelColor)
search.field.SetTitle("Search (All)")
search.field.SetTitleColor(theme.TitleColor)
search.field.SetTitleAlign(tview.AlignLeft)
search.field.SetFieldStyle(tcell.StyleDefault.Italic(true).Underline(true))
search.field.SetFieldBackgroundColor(theme.DefaultBgColor)
search.field.SetFieldTextColor(theme.DefaultTextColor)
search.field.SetBorder(true)
search.field.SetBorderColor(theme.SearchBorderColor)
search.field.SetFocusFunc(func() {
search.field.SetBorderColor(theme.SearchFocusBorderColor)
})
search.field.SetBlurFunc(func() {
search.field.SetBorderColor(theme.SearchBorderColor)
})

search.counter.SetDynamicColors(true)
search.counter.SetTextAlign(tview.AlignRight)
search.counter.SetBorderPadding(1, 0, 0, 0)
return search
}

Expand Down
2 changes: 1 addition & 1 deletion internal/ui/layout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (l *Layout) setupLayout() {

// Left column with search and table
leftColumn := tview.NewFlex().SetDirection(tview.FlexRow).
AddItem(filtersArea, 2, 0, false).
AddItem(filtersArea, 3, 0, false).
AddItem(tableFrame, 0, 4, false)

// Right column with details and output
Expand Down
8 changes: 6 additions & 2 deletions internal/ui/theme/theme.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ type Theme struct {
ModalBgColor tcell.Color
LegendColor tcell.Color
TableHeaderColor tcell.Color
SearchLabelColor tcell.Color
SearchLabelColor tcell.Color
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SearchLabelColor field is no longer used after migrating from SetLabel to SetTitle. This field should be removed to avoid maintaining unused code. The search title now uses theme.TitleColor instead.

Copilot uses AI. Check for mistakes.
SearchBorderColor tcell.Color
SearchFocusBorderColor tcell.Color

// tview global styles (mapped to tview.Styles)
PrimitiveBackgroundColor tcell.Color
Expand Down Expand Up @@ -56,7 +58,9 @@ func NewTheme() *Theme {
ModalBgColor: tcell.ColorDefault,
LegendColor: tcell.ColorDefault,
TableHeaderColor: tcell.ColorBlue,
SearchLabelColor: tcell.ColorPurple,
SearchLabelColor: tcell.ColorPurple,
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialization of SearchLabelColor is no longer necessary since this field is not used anywhere in the codebase after migrating to SetTitle. This line should be removed along with the field declaration.

Copilot uses AI. Check for mistakes.
SearchBorderColor: tcell.ColorWhite,
SearchFocusBorderColor: tcell.ColorGreen,

// tview global styles - use terminal default colors for better compatibility
// By default, tview uses hardcoded colors (like tcell.ColorBlack) which don't
Expand Down
Loading