pipewire: various fixes and cleanup #2021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow the compositor to start working without needing to wait for a nudge/process roundtrip. The PipeWire thread should also now only get woken up when there is actual work to be done.
Also adds a similar mapping function for the colorspace
The corrupted flag doesn't even seem to trigger a renegotiation.
`SPA_PARAM_BUFFERS_size` and `SPA_PARAM_BUFFERS_stride` are params we shouldn't even be setting, mostly because we allocate our own memory for our buffers. PipeWire also recommends not setting them for DMA-BUF types.
Author
|
I pushed a few new things I found while working on multi-planar+modifiers support. I am not done working on part 2, but this PR will definitely become a prerequisite for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some changes I thought would make the pipewire support a little bit more usable. Some of it is simply cosmetic, but the buffer sharing rework is one change I should probably explain:
pw_stream_dequeue_bufferis not thread safe, and it was being called fromrequest_buffer()directly fromdequeue_pipewire_buffer()which is not on the pipewire thread. In addition, theout_bufferatomic was not really useful, as it was exchanged once inrequest_buffer()only to be immediately exchanged back again indequeue_pipewire_buffer()(all on the same thread!)With the new changes, only when
processis called (on the pipewire thread, constantly triggered by the nudges from the compositor) should the buffers be exchanged (more) correctly.