Skip to content

[TF2] NPC damage notice fixes #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Megawolf7339
Copy link

Description

Adds a damage event to Halloween NPCs that didn't have them, meaning they give feedback with hitsounds/killsounds.

@Borloxos
Copy link

Do these changes also apply to the HHH, Merasmus, Monoculus, Skeleton King/Toastmaster, Scarecrows/Mobsters/Salmann (probably, as these are reskinned skeletons), and the RD robots? If not, could you add them to these entities as well?

@Megawolf7339
Copy link
Author

they apply to all bosses, including custom ones, though krampus is implemented in a very strange way where his health never reaches 0, so the kill sound may not work

@Megawolf7339
Copy link
Author

you were right i forgot those

@Borloxos
Copy link

Nice, thank you! I cannot test your branch right now, does this only add damage sounds and kill sounds or are damage numbers also included?

@gidi30
Copy link

gidi30 commented May 16, 2025

Nice, thank you! I cannot test your branch right now, does this only add damage sounds and kill sounds or are damage numbers also included?

Damage sounds and damage numbers are handled by the same hud element so both will happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants