Fix memory leak from include macro in KeyValues::LoadFromBuffer() #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When looking through the code of
KeyValuesclass to understand its format and statements, I noticed a potential memory leak when using the#includemacro.From the looks of things, every time an
#includemacro or a#basemacro is used, it adds all keys from each included file to the current list and deletes the original lists. With#basemacro, it seems to delete all included lists. However, with#includemacro, it always forgets to delete the only/first/last included list, resulting in a small memory leak.I'm new to the Source engine and was not able to debug this issue properly, so I apologize if this isn't a bug.
I was able to catch instances of the
#basemacro being used with a breakpoint upon starting the game but never any#includemacros, even with the implemented fix.