Fix class select animation playback #1285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reusing the shared CTFPlayerModelPanel in the class select screen, SetupFlexWeights would incorrectly calculate a large negative m_flSceneTime. This would result in class select animations freezing when going back and forth in the class select menu. -0.1s start times are allowed to give the system time to lerp to the looping animation. This constant is already used in neighboring code.
|
Finally someone has adresse this! Is there any ways the sound effects could be re-introduced as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This fixes a bug where class select animations will freeze if you go back and forth in the menu.
Related issues:
Before
fix-class-select-anims-before.mp4
After
fix-class-select-anims-after.mp4
Details
When reusing the shared CTFPlayerModelPanel in the class select screen,
SetupFlexWeightswould incorrectly calculate a large negativem_flSceneTime. This would result in class select animations freezing when going back and forth in the class select menu.-0.1s start times are allowed to give the system time to lerp to the looping animation. This constant is already used in neighboring code.
The 2nd commit just replaces this
0.1fmagic number with a macro constant. This is optional, I just thought it would be a nice improvement.