Making some tweaks that would make me happy as a vcpkg maintainer #382
Conversation
|
|
||
| if (STEAMAUDIO_ENABLE_EMBREE) | ||
| if (STEAMAUDIO_ENABLE_EMBREE AND STEAMAUDIO_CLOSED_SOURCE_DEPS) |
There was a problem hiding this comment.
Note that Embree, Radeon Rays, and TrueAudio Next are not technically closed-source dependencies. They're all open source, and Embree is even available on the vcpkg registry (although only versions newer than what we use in Steam Audio at the moment). Totally fine to not enable these features when building for vcpkg, but it might be clearer to just set STEAMAUDIO_ENABLE_EMBREE etc. to OFF in the portfile.cmake.
| ) | ||
|
|
||
| # required to resolve object libraries on import | ||
| install(TARGETS core hrtf EXPORT steam-audio_exports) |
There was a problem hiding this comment.
Why do we need to install the core and hrtf targets? Those are just object files that will eventually be put together into phonon.dll, via the phonon target. I think just the phonon target should be installed, since that's what consumers will want to link against.
| # required to resolve object libraries on import | ||
| install(TARGETS core hrtf EXPORT steam-audio_exports) | ||
|
|
||
| install(EXPORT steam-audio_exports |
There was a problem hiding this comment.
(See above comment.) Do we need to add phonon to the steam-audio_exports?
I am currently working on getting steam-audio available via the vcpkg package manager (see microsoft/vcpkg#40942 ). However, I have had to make a substantial patch. In doing so I whipped up this PR which would minimize the work for a downstream maintainer like myself in the future.
CMAKE_OSXvariables override-able (so you can build just an arm64 or x86_64 library)When the project is marked for export the minimal dependencies linked will be fetched via config mode so they can be tracked during the export process and the dependency chain will be properly exported. In this case the dependencies (mysofa, flatbuffers, pffft) will be found via Config mode which vcpkg or another package manager should provide via its environment.
Happy to make any changes you see fit to this. I'm not married to any of it. Also, if you don't want me to make steam-audio available on vcpkg at all let me know and I can just drop this 😄