Merged
Conversation
…I subpackages - enhance regex to extract both free‐text label and numeric HPO ID - use hpotk.get_term() to look up the ontology term and compare its name - emit a warning if the provided label doesn’t match the ontology’s term name - allow sheets without labels to continue working (backwards compatibility) - fixes missing Phenotype records on both Python_headers_phenocopy_transformation.xlsx and Sydney_Python_transformation.xlsx
- Single method, unified regex for HPO label+ID parsing - Properly handle unparsable HPO cells, missing ontology terms, obsolete terms, and label mismatches - Wrap access to `VariationDescriptor.Expression` and `.location`/alleles in `try/except AttributeError` so CLI won’t crash on protobufs lacking those fields - Eliminate mutable default dict in `Genotype`; rely on `zygosity_code` property and class‐level mapping - All existing tests (genotype, mapper, CLI) now pass, deprecation warning only remains from protobuf internals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.