Add controlled keywords to score set search filter options.

[EstelleDa]

No description provided.

[bencap]

Looks great, thanks Estelle.

[bencap]

Hmm, actually one thing that I noticed based on the front end. If a user searches for 'Other' (or any value which is ambiguous between keyword categories), all results will show up regardless of the intended class being searched. We may need to reqork the way that the controlled keyword search works to accept both a value and a key, similar to how you return both a value and a key. This would let us more precisely match the users' search request.

[EstelleDa]

Thanks for finding this! It's a serious problem.

[bencap]

Thanks for the fix and the new shape. My one suggestion is that API consumers who don't know about this new change are going to be confused with what we did if they try to search by the old keywords.

What I would suggest is adding a model validator and an issue to the backlog to remove it in 6 months or something:

    # TODO#XXX - Remove validator after consumers have had a chance to update
    @model_validator(mode="before")
    @classmethod
    def reject_deprecated_keywords(cls, data):
        if isinstance(data, dict) and ("keywords" in data or "Keywords" in data):
            raise ValueError(
                "'keywords' is no longer supported. Use 'controlled_keywords' with "
                "a list of {key, label} objects to filter by specific keyword groups."
            )
        return data

Now if a user tries to make a request and use the old keywords parameter, they get a really clear error about why it doesn't work and what they need to do to fix it, rather than just a generic error that keywords isn't a valid property.