Add descriptions for lexicon categories #4849
Draft
bellasalmonella wants to merge 13 commits intoVazkiiMods:1.20.xfrom
Draft
Add descriptions for lexicon categories #4849bellasalmonella wants to merge 13 commits intoVazkiiMods:1.20.xfrom
bellasalmonella wants to merge 13 commits intoVazkiiMods:1.20.xfrom
Conversation
Member
|
Nice writing! Did you check ingame how things look/if the text fits properly? |
Collaborator
|
Yup, very nice. The only thing that could probably be adjusted is the way the descriptions directly address the reader, as the rest of the lexicon text doesn't do that. (Except in the Alfheim intro, for lore reasons.) |
Collaborator
|
I had a look in-game now, and unfortunately many of the descriptions are a bit too long to fit into the reduced space of the category description page. |
Collaborator
|
I'm going to add simple, short descriptions for now. Feel free to reword yours to make them fit the page, so we can use those instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request the issue 'write descriptions for lexicon categories'.
Specifically, I have:
en_us.jsonfile.If there are any specific requirements for writing style that I missed, please let me know and I can amend them.