Rewrite Dominant Spark transfer#4963
Merged
TheRealWormbo merged 2 commits intoVazkiiMods:1.20.xfrom Feb 14, 2026
Merged
Conversation
Member
|
given how sensitive this system has been, it would be nice to have some gametests to assert the correctness of things here |
Contributor
Author
|
Do you have a definition for what correct would be? Because this PR does change the behavior somewhat |
cjlarose
added a commit
to cjlarose/Botania
that referenced
this pull request
Feb 15, 2026
The changes in VazkiiMods#4963 generally fixed behaviors associated with establishing and re-establishing mana transfers to dominant sparks, but I think introduced an unintended consequence: it made it possible for dominant sparks to receive `TRANSFER_RATE` mana every tick from each unaugmented spark in range. Prior to the change, a dominant spark could receive at most `TRANSFER_RATE` mana from a single pool per tick. This change restores that behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This was referenced Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4833