-
Notifications
You must be signed in to change notification settings - Fork 9
Added OnSaveEvent #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@samjgriffin89 your pull request is missing pipeline/AutoUpdate.cs. I'm trying to pull the request into https://github.com/1508/Custom-Item-Generator Would be great if you could push it |
Added the pipeline. Thanks for pointing that out, not sure how I missed it. |
Added ToString overrides for some of the simple field types
@dunston I know its been awhile since this was committed, but have you had a chance to review the changes? |
Looking at this stuff now, sorry about the delay. |
So is this maintained anymore or is it not worth continuing on this? |
I did look through your code and was working on folding that into the project when I got side tracked with project work. Tim Braga just wrote a post about this here as well http://allthingssitecore.com/2014/04/07/auto-generating-custom-items-on-save When I looked into it there was more than on way to accomplish this same task, each with it's own pluses and minuses. I went through a few scenarios using both pipelines and events, I would have to go back and look at what the benefits/risks for each approach were exactly, but for example in one case the generation code was getting called repeatedly which is less than ideal. Hopefully fairly soon I will have some time to finish bringing the auto generation code into the project as well as possibly writing a blog post about the various ways that it could be done. |
Yeah, I saw the blog post and think we can definitely improve upon the code I put together - it was certainly a while ago and I haven't touched it in a while. No rush, I was just curious if it was something that was still being maintained and if I should come back to work on it some more. |
Yes in general we are still maintaining the tool, just tough sometimes to find the necessary time to do things in a reasonable way. This feature and some updates based around new versions of Sitecore/.NET are next in the queue. A while back I had Rocks integration mostly done as well, but that was a few years ago and I think things have changed with how you build Rocks plugins. I would like to finish this up at some point, would really be helpful for people that use the CIG and Rocks. |
Added an option in the CustomItem.config to enable an OnSaveEvent that will update existing custom base templates.