Skip to content

Fixed bugs in Instructions.txt #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed bugs in Instructions.txt #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TakeHome/Models/FeedbackForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public String LastName
get;
set;
}
[Required(AllowEmptyStrings = false, ErrorMessage = "Please Provide Eamil")]
[Required(AllowEmptyStrings = false, ErrorMessage = "Please Provide Email")] /* AJH - corrected spelling error */
[RegularExpression("^[a-zA-Z0-9_\\.-]+@([a-zA-Z0-9-]+\\.)+[a-zA-Z]{2,6}$", ErrorMessage = "Please Provide Valid Email")]
[StringLength(200, MinimumLength = 0, ErrorMessage = "First Name Should be min 1 and max 25 length")]
public String Email
Expand Down
3 changes: 2 additions & 1 deletion TakeHome/Views/Feedback/ThankYou.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@model object
<!-- AJH - missing the feedbackform model -->
@model TakeHome.Models.FeedbackForm

@{
ViewBag.Title = "ThankYou";
Expand Down
3 changes: 2 additions & 1 deletion TakeHome/Views/Shared/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
<ul class="nav navbar-nav">
<li>@Html.ActionLink("Home", "Index", "Home")</li>
<li>@Html.ActionLink("About", "About", "Home")</li>
<li>@Html.ActionLink("Feedback", "Index", "Feedback")</li>
<li>@Html.ActionLink("Feedback", "Feedback", "Feedback")</li> <!-- AJH - incorrect controllerName -->
<li>@Html.ActionLink("Contact", "Contact", "Home")</li> <!-- AJH - Link missing from navbar -->
</ul>
</div>
</div>
Expand Down
3 changes: 2 additions & 1 deletion TakeHome/Web.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
<system.web>
<compilation debug="true" targetFramework="4.7"/>
<httpRuntime targetFramework="4.7"/>
<customErrors defaultRedirect="Error" mode="Off" redirectMode="ResponseRewrite">
<!-- AJH - enabling customErrors -->
<customErrors defaultRedirect="Error" mode="On" redirectMode="ResponseRewrite">
</customErrors>
</system.web>
<system.webServer>
Expand Down