-
-
Notifications
You must be signed in to change notification settings - Fork 351
fix: re-add tray icon to macOS #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
should just apply this fix to all platforms anyway I think the tray was removed because apps usually don't have trays on mac? |
oo, so should I just resize it for all platforms? doesn't it break? I can't test for other platforms right now
not sure, but docker, cf warp, etc has tray icon. I kinda find it useful tho for shortcuts, so why not |
|
it would probably be a good compromise to simply make the tray setting opt-in on mac. that way users who want it can still enable it |
|
The way Discord does it is that they only show their own trey icon when you're in a voice chat, to indicate that you're either unmuted/muted/or deafened along with quick actions regarding this. At least to me this would serve as an actual purpose of having a trey icon, instead of common quick actions you would find in the menubar. Though, I'm not really imposed on having different options for users. |
Just checked, there is already a PR for that apparently |
now it is opt-in |
Co-authored-by: V <[email protected]>
|
Will this be implemented? I like to have a tray icon to see if ive some notification, because Ive the dock hidden. |


I just noticed that when I open Vesktop on macOS, it has no tray icon. This was removed in #68 due to its super big size on the menu bar.
This PR fixed it by resizing the icon first instead of passing the icon directly to the tray constructor