Add unchecked return scanner plugin - #85
Open
telemarkdigital-publisher wants to merge 2 commits into
Open
Conversation
Author
|
Pushed a formatter-only update in d00d60a after the PR lint workflow reported Prettier issues in Local verification now passes for the changed plugin:
The refreshed CI run is currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16. Adds an @veridion/plugin-unchecked-return workspace package that detects unchecked Solidity call, send, and delegatecall return values, including ignored calls and assigned-but-unvalidated success flags. Also adds focused tests and lets PluginRegistry accept initial plugins through its constructor for straightforward registration. Verification: corepack pnpm@9.1.0 --filter @veridion/plugin-unchecked-return test; corepack pnpm@9.1.0 --filter @veridion/plugin-unchecked-return typecheck; corepack pnpm@9.1.0 --filter @veridion/plugin-unchecked-return lint; corepack pnpm@9.1.0 --filter @veridion/plugin-unchecked-return build; corepack pnpm@9.1.0 --filter @veridion/scanner-core test; corepack pnpm@9.1.0 --filter @veridion/scanner-core typecheck; corepack pnpm@9.1.0 --filter @veridion/scanner-core lint; corepack pnpm@9.1.0 --filter @veridion/scanner-core build.