Rename the misnamed NUnit VerifyBase.ThrowsValueTask<T> overload - #1886
Merged
Conversation
VerifyBase declared ThrowsValueTask<T>(Func<Task<T>>), which forwards to Verifier.ThrowsTask. The name was a copy paste error: the static API and MSTest's VerifyBase both call this ThrowsTask<T>. So NUnit's VerifyBase had no generic ThrowsTask at all, and ThrowsValueTask was overloaded across unrelated Task<T> and ValueTask<T> signatures. Code moved between the static and instance APIs, or from MSTest, did not compile against the name it expected. Renamed rather than kept alongside an obsolete forwarder, since a forwarder would preserve the overload confusion that is the actual problem here. Callers of the old name change to ThrowsTask, which is the method they were already reaching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VerifyBase declared ThrowsValueTask(Func<Task>), which forwards to Verifier.ThrowsTask. The name was a copy paste error: the static API and MSTest's VerifyBase both call this ThrowsTask.
So NUnit's VerifyBase had no generic ThrowsTask at all, and ThrowsValueTask was overloaded across unrelated Task and ValueTask signatures. Code moved between the static and instance APIs, or from MSTest, did not compile against the name it expected.
Renamed rather than kept alongside an obsolete forwarder, since a forwarder would preserve the overload confusion that is the actual problem here. Callers of the old name change to ThrowsTask, which is the method they were already reaching.