Validate UseTextForParameters as a file name - #1893
Merged
Merged
Conversation
The text is appended to the snapshot file name verbatim, with no FileNameCleaner
pass, but it was validated with AgainstBadExtension, which only rejects a
leading period and directory separators. The sibling naming APIs UseFileName,
UseTypeName and UseMethodName all use the file name guard.
So UseTextForParameters($"{time:HH:mm}") put a ':' in the path: on Windows the
received write silently went to an NTFS alternate data stream, so no received
file appeared at all, and on net4x it failed deep in IO rather than as a clear
argument error. '*' and '?' failed at write time.
'#' is rejected too, since it starts the indexed-target namespace and would make
one case's files look like another case's targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text is appended to the snapshot file name verbatim, with no FileNameCleaner pass, but it was validated with AgainstBadExtension, which only rejects a leading period and directory separators. The sibling naming APIs UseFileName, UseTypeName and UseMethodName all use the file name guard.
So UseTextForParameters($"{time:HH:mm}") put a ':' in the path: on Windows the received write silently went to an NTFS alternate data stream, so no received file appeared at all, and on net4x it failed deep in IO rather than as a clear argument error. '*' and '?' failed at write time.
'#' is rejected too, since it starts the indexed-target namespace and would make one case's files look like another case's targets.