Guard TUnit parameter binding and null TestContext - #1894
Merged
Conversation
Two fixes in the same method, sharing one helper. TestMethodArguments holds the raw pre-binding arguments: TUnit bundles a params array at invocation time. SetParameters was called with them unconditionally, so a [Arguments(1, 2, 3)] test with a params int[] parameter ran fine under TUnit but threw 'The number of passed in parameters (3) must not exceed the number of parameters for the method (1)' from every Verify call. The argument count is now compared with the parameter name count first, matching MSTest and XunitV3. TestContext.Current is nullable, and is null in a [Before(TestSession)] hook or any code that does not flow the test context. Both BuildVerifier and VerifyChecks.Run dereferenced it with !, giving a bare NullReferenceException. They now throw the same kind of explanatory error the other adapters do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the same method, sharing one helper.
TestMethodArguments holds the raw pre-binding arguments: TUnit bundles a params array at invocation time. SetParameters was called with them unconditionally, so a [Arguments(1, 2, 3)] test with a params int[] parameter ran fine under TUnit but threw 'The number of passed in parameters (3) must not exceed the number of parameters for the method (1)' from every Verify call. The argument count is now compared with the parameter name count first, matching MSTest and XunitV3.
TestContext.Current is nullable, and is null in a [Before(TestSession)] hook or any code that does not flow the test context. Both BuildVerifier and VerifyChecks.Run dereferenced it with !, giving a bare NullReferenceException. They now throw the same kind of explanatory error the other adapters do.