Allow a recording to be started again once consumed - #1896
Merged
Conversation
TryStop runs inside the engine's child async context, so its asyncLocal null
never flows back to the test. The shared State is deliberately left cleared and
paused instead, which IsRecording reads correctly as not recording.
Start only checked for a non null state though, so the supported pattern
Recording.Start(); ... await Verify(x);
Recording.Start(); ... await Verify(y);
threw 'Recording already started', which was not true: the first recording had
already been consumed.
The state now carries a Stopped flag, and Start replaces a stopped state while
still rejecting a live one.
# Conflicts: # docs/recording.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryStop runs inside the engine's child async context, so its asyncLocal null never flows back to the test. The shared State is deliberately left cleared and paused instead, which IsRecording reads correctly as not recording.
Start only checked for a non null state though, so the supported pattern
threw 'Recording already started', which was not true: the first recording had already been consumed.
The state now carries a Stopped flag, and Start replaces a stopped state while still rejecting a live one.